Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with receiving messages containing character ":" #14

Open
gigadani opened this issue Feb 15, 2021 · 1 comment
Open

Issue with receiving messages containing character ":" #14

gigadani opened this issue Feb 15, 2021 · 1 comment

Comments

@gigadani
Copy link

gigadani commented Feb 15, 2021

I'm trying to catch #channel messages containing URLs and bumped my forehead against the bug that colon character terminates itself and all remaining text from a message.

In other words, a message
hello here's my url https://www.google.fi
gets garbled to
hello here's my url https

I looked at the code in IrcClient.cs that handles parsing PRIVMSG messages and messed up my pants realizing that the parsing is done by splitting with ":" delimiter.

Maybe that's where the cause of this problem is? I'm still in doubt whether this really is a problem or whether I'm just dumb, as over 10 projects use SimpleIRCLib and no-one has mentioned this bug yet.

@bman87
Copy link

bman87 commented Jul 10, 2023

I just built an entire project that uses this library.. only to find this bug... WTF.. My project deals with URLs in messages and this breaks the entire thing. I will have to write my own parser using OnRawMessageReceived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants