Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses are always using the change path #4

Open
jcramer opened this issue Sep 29, 2020 · 1 comment
Open

Addresses are always using the change path #4

jcramer opened this issue Sep 29, 2020 · 1 comment

Comments

@jcramer
Copy link

jcramer commented Sep 29, 2020

The following line shows that change addresses (a.k.a. internal) are always being used. In the path 0/%d, the 0 means the addresses should be external. When the path is 1/%d, addresses would be internal (or "change").

For the BCHD implementation of "createNewAddress" it would be nice to be able to be able to have a parameter for "isChange".

@Ekliptor
Copy link
Owner

Ekliptor commented Oct 6, 2020

I can add a parameter for BCHD for that. But wouldn't be available to REST Bitcoin (or other APIs) afaik.

And just to be sure:

  1. So the default value of change should be true or false?
  2. The hdpath 0/%d is ok or should also be changed to 1/%d?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants