Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify values used for cell/vertex centering in AMReX and CarpetX #77

Open
rhaas80 opened this issue Apr 12, 2023 · 0 comments
Open

unify values used for cell/vertex centering in AMReX and CarpetX #77

rhaas80 opened this issue Apr 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@rhaas80
Copy link
Member

rhaas80 commented Apr 12, 2023

Currently AMReX's CELL and VERTEX enums are 0 and 1 while CarpetX using 1 and 0 for cell and vertex centered data (user visible in loop<IDXTYPE, IDYTYPE, IDZTYPE> templates).

To avoid confusion this should be made uniform among the library and its client code.
@rhaas80 rhaas80 added the enhancement New feature or request label Apr 12, 2023
@rhaas80 rhaas80 changed the title unify values used for cell/vertex centering in AMReX and Carp[etX unify values used for cell/vertex centering in AMReX and CarpetX Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhaas80