Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map<clause_t, valid_t> looks wrong in schedule.cxx #27

Open
eschnett opened this issue Feb 24, 2023 · 4 comments
Open

map<clause_t, valid_t> looks wrong in schedule.cxx #27

eschnett opened this issue Feb 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@eschnett
Copy link
Collaborator

For example, line 1774 in schedule.cxx reads:

    map<clause_t, valid_t> isread;

This maps a clause_t (which contains a valid_t field) to a valid_t. This looks wrong. @stevenrbrandt suggests to have the clause_t comparison operator ignore the valid_t field. @eschnett thinks that maybe this valid_t field should be there in the first case, at least not for this map.

@stevenrbrandt
Copy link
Contributor

I'm slightly confused. What is "the first case?"

@eschnett
Copy link
Collaborator Author

That's just an English expression, read as "[...] field should not be there".

@stevenrbrandt
Copy link
Contributor

Ah, the English expression is actually "in the first place." So we should change the == and < operators?

@eschnett
Copy link
Collaborator Author

Not yet, the code looks wrong, I want to investigate first.

@eschnett eschnett added the bug Something isn't working label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants