Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarpetX: Should boundary parameters be renamed to boundary_lower? #137

Open
SamuelCupp opened this issue May 31, 2023 · 0 comments
Open

Comments

@SamuelCupp
Copy link
Contributor

As discussed in today's call, the boundary_x, boundary_y, and boundary_z parameters only set the lower boundaries. This is due to historical reasons relating to reflection boundaries. However, it might make more sense to have boundary_lower.

This naming convention is present in all the boundary parameter names (reflection_x and reflection_upper_x, linear_extrapolation_x_vars and linear_extrapolation_upper_x_vars, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant