-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual validation run for room owners #33
Comments
It is something that's been on my mind for a while because of lobby generation. Here's my braindump about it from a few weeks ago:
|
If it's not demanding, validation status should be visible to everybody who can see the room.
May need to include icons or text |
Yup, that was a brain dump I made, haven't re-read any of it but your input is very welcome, thank you |
A few more thoughts about this: We can automatically revalidate YAMLs when an apworld changes in the room in 2 places.
The main issue with that is knowing what to revalidate. The validation status should probably contain the apworlds/versions the YAML has been checked with. |
When rooms that have validation disabled allow a manual validation run to catch surface level problems.
For example, the latest Hades release provides template YAMLs with outdated key names. Yes, this would be caught if the submitter solo genned and if the room had validation enabled, but this mitigates a downside of disabling validation(...) and can inform room owners ahead of time.
Easy mode:
Easy NG+ mode:
uploaded_date
to YAMLs and a way to see/sort by that #29The text was updated successfully, but these errors were encountered: