In MSFR_pipeline.py line 78, should "`if self.save_loss > np.mean(loss_list):`" be "`if self.save_loss < np.mean(loss_list):`" instead? #2

SimpleXP · 2024-11-22T09:11:03Z

https://github.com/Ehteshamciitwah/MSFR/blob/3bf6415a68dc1ba4b9fdc5fbef724ca1345ce8b8/models/MSFR/MSFR_pipeline.py#L78C1-L78C52

In MSFR_pipeline.py line 78, should "if self.save_loss > np.mean(loss_list):" be "if self.save_loss < np.mean(loss_list):" instead?
as I tested, the loss decreases during training.

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In MSFR_pipeline.py line 78, should "`if self.save_loss > np.mean(loss_list):`" be "`if self.save_loss < np.mean(loss_list):`" instead? #2

In MSFR_pipeline.py line 78, should "`if self.save_loss > np.mean(loss_list):`" be "`if self.save_loss < np.mean(loss_list):`" instead? #2

SimpleXP commented Nov 22, 2024

In MSFR_pipeline.py line 78, should "if self.save_loss > np.mean(loss_list):" be "if self.save_loss < np.mean(loss_list):" instead? #2

In MSFR_pipeline.py line 78, should "if self.save_loss > np.mean(loss_list):" be "if self.save_loss < np.mean(loss_list):" instead? #2

Comments

SimpleXP commented Nov 22, 2024

In MSFR_pipeline.py line 78, should "`if self.save_loss > np.mean(loss_list):`" be "`if self.save_loss < np.mean(loss_list):`" instead? #2

In MSFR_pipeline.py line 78, should "`if self.save_loss > np.mean(loss_list):`" be "`if self.save_loss < np.mean(loss_list):`" instead? #2