-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing email address of an existing member? #10
Comments
Hi @andredasilvapinto , Maybe... but what changes if we do so? It seems, nothing. Probably, we should move the |
yes, that's what I meant. email_address should be a field. it does change the email in that case. |
@basiliscus I can confirm making it mutable should work. the idea is that subscriber_hash should stay the hash of the old email (coming from the constructor). then the caller can change the field email_address on the method and update subscriber's email. The use case is pretty common, users changing their emails from time to time and ideally change on a platform will reflect in Mailchimp. Also see https://stackoverflow.com/questions/32224697/mailchimp-api-v3-0-change-subscriber-email discussion, the change from November 2016 added this ability to the API How can we get that pull request approved? |
Shouldn't this be marked as a field too:
https://github.com/Ecwid/maleorang/blob/master/src/main/java/com/ecwid/maleorang/method/v3_0/lists/members/EditMemberMethod.kt#L36
in order to conform to:
http://developer.mailchimp.com/documentation/mailchimp/reference/lists/members/#edit-patch_lists_list_id_members_subscriber_hash
?
The text was updated successfully, but these errors were encountered: