Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total genome counter in log is off (warning message) #585

Open
GabeAl opened this issue Apr 26, 2024 · 1 comment
Open

Total genome counter in log is off (warning message) #585

GabeAl opened this issue Apr 26, 2024 · 1 comment
Labels
error Help required for a GTDB-Tk error.

Comments

@GabeAl
Copy link

GabeAl commented Apr 26, 2024

Funny little minor glitch. I think it's using the counter for "genomes passing animo acid filter" instead of the total. This leads to fun warnings like:
[2024-04-25 14:25:09] WARNING: 2 of 1 genomes have a warning (see summary file).

It knows "2 genomes identified as archaeal" but because "1 archaeal user genomes have amino acids in <10.0% of columns in filtered MSA" (and also didn't get classified through ANI screening, ending up "Unclassified Archaea"), it likely uses that counter instead. The other one gets classified up to the class level, which is fine.


user_genome | classification
-- | --
genome_827| d__Archaea;p__Thermoproteota;c__DRAE01;o__;f__;g__;s__
genome_17632 | Unclassified Archaea


## Environment
- [ ] Installed via pip (include the output of `pip list`)
- [x] Using a conda environment (include the output of `conda list && conda list --revisions`)
- [ ] Using a Docker container (include the `IMAGE ID` of the container)

## Server information
- CPU: AMD Ryzen Threadripper PRO 5995WX 64-Cores
- RAM: MemTotal:       1056641580 kB
- OS: Clear Linux (Kernel 6.7.9)

## Debugging information
- [x] `gtdbtk.log` has been included (drag and drop the file to upload).
- [ ] Genomes have been included (if possible, and there are few).

Log:
[gtdbtk.log](https://github.com/Ecogenomics/GTDBTk/files/15129984/gtdbtk.log)

## Additional comments
Not a big deal and this probably doesn't affect any inner workings. 
@GabeAl GabeAl added the error Help required for a GTDB-Tk error. label Apr 26, 2024
@pchaumeil
Copy link
Collaborator

Hi,
Thanks for your feedback, I will have a look at this.
As you said , this will not affect the final GTDB-Tk results.

pchaumeil added a commit that referenced this issue Sep 3, 2024
Rewriting warning counter based on issue #585 . counters have been replaced by multiple lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error Help required for a GTDB-Tk error.
Projects
None yet
Development

No branches or pull requests

2 participants