-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add the Deltares World Flood dataset #58
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 72.25% 69.89% -2.37%
==========================================
Files 19 20 +1
Lines 739 764 +25
==========================================
Hits 534 534
- Misses 205 230 +25 ☔ View full report in Codecov by Sentry. |
If the file is too big you can add tests to run locally but keep them out of CI. Also note keywords are pretty standardized here, so go for I would also just use Thinking about this, we really need a trait interface for dimensional keywords so we can automatically make series out of them. It's a bit hacky and specific how its currently done, Rasters.jl just special cases See: |
Description at https://planetarycomputer.microsoft.com/dataset/deltares-floods and https://nbviewer.org/github/microsoft/AIforEarthDataSets/blob/main/data/deltares-floods.ipynb Basically a computation of coastal flooding with certain parameters on a specified DEM.
In this case year is actually a parameter, not a time - it indicates the year of reference for sea level. |
aec1628
to
648b12d
Compare
julia> Raster(Deltares{WorldFlood}, nothing; lazy = true)
[ Info: No `name` or `key` keyword provided, using first valid layer with name `:inun`
432000×216000×1 Raster{Union{Missing, Float32},3} inun with dimensions:
X Mapped{Float64} Float64[-180.00000003333332, -179.9991667, …, 179.99833329985603, 179.99916663318936] ForwardOrdered Regular Points crs: EPSG mappedcrs: EPSG,
Y Mapped{Float64} Float64[-90.00000003326134, -89.99916669992801, …, 89.9983333, 89.99916663333333] ForwardOrdered Regular Points crs: EPSG mappedcrs: EPSG,
Ti Sampled{Dates.DateTime} Dates.DateTime[Dates.DateTime("2010-01-01T00:00:00")] ForwardOrdered Irregular Points
extent: Extent(X = (-180.00000003333332, 179.99916663318936), Y = (-90.00000003326134, 89.99916663333333), Ti = (Dates.DateTime("2010-01-01T00:00:00"), Dates.DateTime("2010-01-01T00:00:00")))
missingval: missing
crs: EPSG:4326
mappedcrs: EPSG:4326
from file:
/Users/anshul/downloads/Deltares/WorldFlood/GFM_global_NASADEM90m_2050slr_rp0100_masked.nc Not sure what to put as a layer - might end up being the year. |
Yeah, we a squishing a wide range of datset shapes into a regular structure, and it doesnt always work so cleanly. What are the options to be layers? You can just have a single layer name |
Just remembered this PR. SRTM already doesn't have a We may need to add/fix dispatch in Rasters.jl to handle that. |
Bump! |
Description at https://planetarycomputer.microsoft.com/dataset/deltares-floods and https://nbviewer.org/github/microsoft/AIforEarthDataSets/blob/main/data/deltares-floods.ipynb
Basically a computation of coastal flooding with certain parameters (return time, year) on a specified DEM.
This is ~1gb in size.
Needs docs and tests (if possible)