Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookiebanners.service.mode overrides cookie blocking settings #176

Open
marty60 opened this issue Sep 5, 2024 · 8 comments
Open

cookiebanners.service.mode overrides cookie blocking settings #176

marty60 opened this issue Sep 5, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@marty60
Copy link

marty60 commented Sep 5, 2024

When through settings/privacy & security/custom it is checked to "All Cookies (will cause websites to break)" 128.2.0 still allows cookies. One site tested is old.reddit.com, it doesn't do it with every site but you can find the cookies in Manage Data. Also tried blocking them individually through Manage Exceptions and they still were set. Confirmed with a new profile with the same results.

@K4sum1
Copy link
Member

K4sum1 commented Sep 6, 2024

Can you check if stock Firefox works? I don't think any changes I've made would affect this behavior.

@marty60
Copy link
Author

marty60 commented Sep 6, 2024

None of the official Firefox versions I'm seeing this (115.15, 128esr, nightly). So far only https://old.reddit.com is doing it although msn.com does it occasionally.

@K4sum1
Copy link
Member

K4sum1 commented Sep 7, 2024

Can you check previous releases to see where the issue began? I'm too busy to debug this so I'll probably only get around to fixing after I release 130.

@K4sum1
Copy link
Member

K4sum1 commented Sep 7, 2024

This might be a bug with Firefox, but some change in both my fork and Waterfox exposes it. It's the same issue as this BrowserWorks/Waterfox#3490

Both r3dfox and Waterfox allow cookies for Google and Reddit. I can't get MSN to load on my end, but I assume it would be the same there too.

image

@K4sum1
Copy link
Member

K4sum1 commented Sep 7, 2024

I remembered dev tools exists, so I took a look at the storage tab, and noticed the Reddit cookie is named eu_cookie. This made me think of something. I had traced the Waterfox issue to G6.0b3, and I looked at the changes in that version again.

cookiebanners.service.mode and cookiebanners.service.mode.privateBrowsing

G6.0b3 set these both to 2, and a bit back I also set both to 2 in r3dfox. These override the block all cookies setting and set cookies so you don't get spammed with the EU cookie prompts. I assume someone blocking all cookies would also use uBlock Origin or similar which also blocks said prompts. So I don't think it's of much use to set these if you block all cookies, but I'll leave that up to the user. I'd prefer to have them set for new users for a better user experience, so I'll leave them as is.

I'm not sure what to do here though. Should I report the bug to Mozilla since it is setting cookies even though I told it to block all? Should I make a preference for it in settings with a note about it overriding the cookies setting? Should I just leave it as is?

@marty60
Copy link
Author

marty60 commented Sep 7, 2024

With 115.15 I checked those prefs and they're set to 0 so I did the same with your version and now reddit's not setting any cookies. Maybe that's the answer, although I never even knew about that feature. I'm assuming when at 0 it's completely disabled? I've never run into noticeable problems so I'll leave it there for now and see how it goes.

@K4sum1
Copy link
Member

K4sum1 commented Sep 16, 2024

Not sure how to set a boolean option that would change both between 0 and 2 just yet.

@K4sum1 K4sum1 changed the title 128esr allows cookies even when blocked cookiebanners.service.mode overrides cookie blocking settings Sep 16, 2024
@K4sum1
Copy link
Member

K4sum1 commented Sep 16, 2024

Edited title to be more relevant

@K4sum1 K4sum1 added the enhancement New feature or request label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants