Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems after installing browser themes. #140

Open
EDSln opened this issue Jul 24, 2024 · 21 comments
Open

Problems after installing browser themes. #140

EDSln opened this issue Jul 24, 2024 · 21 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@EDSln
Copy link

EDSln commented Jul 24, 2024

There are two problems at once, with and without Aero.
With the Windows 7 Base theme with any settings, the theme is not applied to the window title bar.
r3dfox-128.0.2:
2

It should be like Firefox 115
1

With Aero the theme in the window title bar is applied after disabling the "Force enable caption bar transparency" setting, but the window control buttons, Minimize, Close are missing.
3

If it's configurable in about:config, what are the settings?

@K4sum1
Copy link
Member

K4sum1 commented Jul 24, 2024

The issue seems to be that -moz-window-titlebar coloring is not getting overridden by the lwtheme properly. I would need to figure out where this began.

@K4sum1
Copy link
Member

K4sum1 commented Jul 24, 2024

I really need someone that can help me with my browser. I feel burnt out, and I don't want to do anything. I'm not sure how long I'll feel this way. It just hit me after I started to investigate the issue.

If you want to help fix it try previous releases to find the last to work, also disable r3dfox themes and styles as that seems to impact it, but I can probably easily fix it. Classic theme seems to be even more broken, so check it too. After that, if you know how to use browser toolbox, investigate why the default theme is overriding the lwtheme and see if it's potentially an easy CSS fix.

I'm going to lie down now, and not to sleep, or maybe I do end up napping idk.

@EDSln
Copy link
Author

EDSln commented Jul 24, 2024

Disabling the r3dfox theme did not help. I'll look for after which version the themes broke. I'd like to help, but I'm completely clueless about CSS. :(

@jonm58
Copy link

jonm58 commented Jul 24, 2024

on Windows 11(have Aero Glass)
Windows_11
btw,The button is just hidden.

@EDSln
Copy link
Author

EDSln commented Jul 24, 2024

Checked many versions, problems vary from version to version, and depend on whether the window is expanded full screen or not, but everywhere after version 122 something doesn't work.
Beta 95% branded v122.0.1-2 - no problems.
Beta Aero v123.0.2 aero bug as on the screenshot below. basic in windowed mode bookmark bar without theme.
Beta Aero v123.0.2-2 aero bug as on the screenshot below. basic in window mode bookmark bar without theme.
124.0.2 aero bug as on the screenshot below. basic - in window mode bookmark bar without theme.
123-124 bug aero
124.0.3 aero - no problems. basic - full screen - no problems, in window mode - no theme.
Release v125.0rc aero - no problems. basic - full screen - no problems, window mode - no theme.
Release v125.0rc2 aero - no problems. basic - full screen no problems, window mode - no theme.
Release v125rc3 aero - no buttons. basic - full screen - no problems, window mode - bookmarks panel without theme.
125.0.3 aero - no buttons. basic - full screen no problems, window mode - no theme.
124-125 basic no theme
126.0+ aero - no buttons. basic - window title bar without theme.

@jonm58
Copy link

jonm58 commented Jul 24, 2024

图片
I suspect that Firefox's browser theme is at the top level, causing problems with native patch controls.

@SoftwareType
Copy link

on Windows 11(have Aero Glass) Windows_11 btw,The button is just hidden.

Without Aero Glass it also happens, but for some reason I suspect it is because of how Firefox handles the buttons. At default, Firefox always used their custom buttons, and, probably, those themes are trying to detect the buttons (and adjust the colors of it) but it fails

@KT907
Copy link

KT907 commented Jul 25, 2024

If you disable hardware acceleration and webrender in about:config, the buttons are displayed fine in third-party themes. Presumably, in this direction you need to look for compatibility errors.

@EDSln
Copy link
Author

EDSln commented Jul 25, 2024

Yes, it looks like the problem is the wrong order of layers, there are buttons under the theme.
not naming

@K4sum1
Copy link
Member

K4sum1 commented Jul 25, 2024

#59

@EDSln
Copy link
Author

EDSln commented Jul 25, 2024

Wouldn't it be easier to add an option, if possible, that completely reverts the Win 10 theme? Those who have the theme installed don't see the system window title bar anyway, and the fact that the window close buttons won't be from 7 is not so terrible.

@jonm58
Copy link

jonm58 commented Jul 25, 2024

Wouldn't it be easier to add an option, if possible, that completely reverts the Win 10 theme? Those who have the theme installed don't see the system window title bar anyway, 和 the fact that the window close buttons won't be from 7 is not so terrible.

set widget.ev-native-controls-patch.override-win-version to 10,you can get Win 10 theme

@EDSln
Copy link
Author

EDSln commented Jul 25, 2024

set widget.ev-native-controls-patch.override-win-version to 10,you can get Win 10 theme

Thanks, no problem with Aero now.
1

But the Basic theme is still without the browser theme in the window title bar. Perhaps the problem is that Win10 simply can't have a Basic theme.

@K4sum1
Copy link
Member

K4sum1 commented Jul 28, 2024

I can't fix this without many days of trying and probably failing to fix the cause. This is something I need external help with.

@K4sum1 K4sum1 added bug Something isn't working help wanted Extra attention is needed labels Sep 21, 2024
@J4CKED
Copy link

J4CKED commented Oct 30, 2024

After the update (129.0.2 > 132.0), the min, max and close buttons disappeared.
As a temporary workaround, I installed this extension https://addons.mozilla.org/en-US/firefox/user/18029308/

@EDSln
Copy link
Author

EDSln commented Oct 30, 2024

The buttons are behind the theme, so you can't see them, but if you click where they should be, the window will close or minimize.

@J4CKED
Copy link

J4CKED commented Oct 30, 2024

Yes, I know, but I prefer to see them. I improved the buttons from the extension a little.
Untitled-1

@EDSln
Copy link
Author

EDSln commented Oct 30, 2024

In about:config find the widget.ev-native-controls-patch.override-win-version parameter and set it to 10, this will enable the buttons, but they will be styled 10 but in their place.

@J4CKED
Copy link

J4CKED commented Oct 30, 2024

I did that, but those buttons are too big. I like the nice look.

@K4sum1
Copy link
Member

K4sum1 commented Oct 30, 2024

I don't know how to fix this. I would need someone smart to figure this out and pr a fix.

@J4CKED
Copy link

J4CKED commented Nov 2, 2024

I noticed that some windows 7 styles (msstyles) do not work well with the “force enable caption bar transparency” option.
So I modified a favorite style to make it work with solid color. I also made a second one, more gray-dark.
Firefox Arc Dark Theme and “Translucent design” option in 3rdfox. So far I like it.
r3dfox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants