-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public key resolution #122
Comments
I am happy to update RFC001 to reflect this, and we can release it for v2.2. Any objections? @andreasabr @endimion @ntsbs @ed-curran @georgepadayatti |
We support x5c for sd-jwt vc like this already, so good for me. |
I am good as well... already implemented this as part of the ITB.. so if everyone is happy let me know when to do that... |
no objections from my side, go ahead @lalc |
After a short discussion with @endimion , I decided to write down my doubts regarding public key resolution and how it is implemented in the EWC conformance issuer (https://dss.aegean.gr/rfc-issuer/). This comment is very long... so you can go directly to the summary that it's at the end of this comment. In the RFC001, link to the HAIP should be updated to:
Should that be well specified in the RFC001? I will create a pull request for suggesting that and clarifying this point: https://github.com/EWC-consortium/eudi-wallet-rfcs/blob/main/ewc-rfc001-issue-verifiable-credential.md#appendix-a-public-key-resolution But firstly, let's check what says HAIP and IETF regarding public key resolution and why the EWC conformance issuer should include kid (or x5c) claim in sd-jwt:
Current sd-jwt signed by the EWC conformance issuer is signed by using the first way. Let's see it using an example:
sd-jwt decoded:
According to the HAIP, what it is missing here is the kid claim into the header that should contain the value Other issue is how to perform the web key resolution so that the verifier can verify the issuer's signature. Just now, the process is:
Well, according to the IETF, the way for the verifier to resolve the key is defined here: Section 5. JWT VC Issuer Metadata The issuer could express the key using certificates. In fact it's the title of the discussion/issue started by @mat-work. For that the EWC conformance issuer should make some changes:
SUMMARY
|
@mat-work @georgepadayatti @endimion Could you please check and comment above by @pcosio? |
Hey all, I mostly agree with Pablo, so bulletts 1 and 3 have been resolved now. With respect with bullet 2, and how to perform the web key resolution ... do I understnad correctly that this " /.well-known/jwt-vc-issuer" comes from HAIP in combination with OIDC4VCI v14? Because in the current RFCs we support v13 maybe this is what is causing the issu? Of course exposing the keys under a different endpoint is not a big deal but we need to clarify this to ensure interoperability |
thanks for the response @endimion . I agree with you about bullet 2 ("/.well-known/jwt-vc-issuer"). I think it comes directly from IETF sd-jwt vc, but both OID4VCI draft 13 and draft 14 defines it as "/.well-known/openid-credential-issuer". So, probably we should not take it into account. I've checked that HAIP does not say anything about the path of the credential issuer metadata |
awesome, so all issues resolved for now? If so can we close this? |
Hi @endimion The only non-compliance issue that I see with regards to the HAIP is the url where is published the issuer metadata. HAIP points that to the IETF (draft 01) and it's defined there that it must be "/.well-known/jwt-issuer". But now, I am not sure how it should be managed. Maybe, the way how public key resolution is currently done (web-based key resolution with metadata url paths defined in OID4VCI) could be specified here? What do you think? |
RFC001, RFC002, RFC003, and RFC005 include an appendix related to public key resolution.
For SD-JWT, it would be beneficial to clarify the case of signing credentials using X.509 certificates.
As per the SD-JWT specification, the public key should be extracted from the certificate chain present in the
x5c
header of the Issuer-signed JWT. This includes validating the X.509 certificate chain and ensuring the iss value matches the SAN entry in the end-entity certificate.Please refer to the full specifications for additional context.
The text was updated successfully, but these errors were encountered: