From deb114e8bfef096cc6a5576c17c1cef49b18fac0 Mon Sep 17 00:00:00 2001 From: peverwhee Date: Fri, 30 Aug 2024 16:43:52 -0600 Subject: [PATCH 1/5] add PR templates --- .github/PULL_REQUEST_TEMPLATE/develop-template.md | 14 ++++++++++++++ .github/PULL_REQUEST_TEMPLATE/main-template.md | 6 ++++++ 2 files changed, 20 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/develop-template.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/main-template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/develop-template.md b/.github/PULL_REQUEST_TEMPLATE/develop-template.md new file mode 100644 index 00000000..cc43fcfc --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/develop-template.md @@ -0,0 +1,14 @@ +Originator(s): + +Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): + +Describe any changes made to the namelist: + +List all files eliminated and why: + +List all files added and what they do: + +List all existing files that have been modified, and describe the changes: +(Helpful git command: `git diff --name-status development...`) + +List any test failures: diff --git a/.github/PULL_REQUEST_TEMPLATE/main-template.md b/.github/PULL_REQUEST_TEMPLATE/main-template.md new file mode 100644 index 00000000..4e108632 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/main-template.md @@ -0,0 +1,6 @@ +Tag name: +Originator(s): + +List all `develop` PR URLs included in this PR and a short description of each: + +List all test failures: From c63386f3cf40e7df10d47471550a5252bb89bd65 Mon Sep 17 00:00:00 2001 From: peverwhee Date: Fri, 30 Aug 2024 16:51:55 -0600 Subject: [PATCH 2/5] add default template --- .github/pull_request_template.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..1b30b726 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,4 @@ +Please go the the `Preview` tab and select the appropriate PR template: + +* [Develop branch](?expand=1&template=develop-template.md) +* [Main branch](?expand=1&template=main-template.md) From 0ce6e39bef5ac9c030668c4b33a20aacc08878cd Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Wed, 4 Sep 2024 11:19:22 -0600 Subject: [PATCH 3/5] Update develop-template.md --- .github/PULL_REQUEST_TEMPLATE/develop-template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE/develop-template.md b/.github/PULL_REQUEST_TEMPLATE/develop-template.md index cc43fcfc..ae840af1 100644 --- a/.github/PULL_REQUEST_TEMPLATE/develop-template.md +++ b/.github/PULL_REQUEST_TEMPLATE/develop-template.md @@ -12,3 +12,5 @@ List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...`) List any test failures: + +Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? From 18a0ff399de2eb4114a3a736e709410fe61dc62e Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Wed, 4 Sep 2024 11:46:36 -0600 Subject: [PATCH 4/5] Update main-template.md --- .github/PULL_REQUEST_TEMPLATE/main-template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/main-template.md b/.github/PULL_REQUEST_TEMPLATE/main-template.md index 4e108632..699d5887 100644 --- a/.github/PULL_REQUEST_TEMPLATE/main-template.md +++ b/.github/PULL_REQUEST_TEMPLATE/main-template.md @@ -1,4 +1,4 @@ -Tag name: +Tag name (The PR title should also include the tag name): Originator(s): List all `develop` PR URLs included in this PR and a short description of each: From ed5fcb92eca64e7f34200cbce3580e42b17743f4 Mon Sep 17 00:00:00 2001 From: Courtney Peverley Date: Tue, 19 Nov 2024 12:54:20 -0700 Subject: [PATCH 5/5] Update main-template.md --- .github/PULL_REQUEST_TEMPLATE/main-template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/main-template.md b/.github/PULL_REQUEST_TEMPLATE/main-template.md index 699d5887..ffda41a0 100644 --- a/.github/PULL_REQUEST_TEMPLATE/main-template.md +++ b/.github/PULL_REQUEST_TEMPLATE/main-template.md @@ -1,6 +1,6 @@ Tag name (The PR title should also include the tag name): Originator(s): -List all `develop` PR URLs included in this PR and a short description of each: +List all `develop` PR numbers included in this PR and the title of each: List all test failures: