Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused tropopause methods in tropopause_find #116

Open
jimmielin opened this issue Sep 3, 2024 · 0 comments
Open

Remove unused tropopause methods in tropopause_find #116

jimmielin opened this issue Sep 3, 2024 · 0 comments
Labels
cleanup This issue indicates an opportunity for code cleanup.

Comments

@jimmielin
Copy link
Member

@nusbaume wrote during the code review (#112) for tropopause_find:

I know we are generally trying to avoid clean-up for now, but I think it would be good make an issue reminding us to eventually remove all tropopause algorithm options that aren't being used currently in tropopause_find_run, as my suspicion is that some of these options aren't used at all anymore.

This is an issue as a reminder to remove these unused methods. All combinations used in current CAM have been included in tropopause_find; other methods remain as method subroutines but are inaccessible in CCPP.

  integer, parameter    :: TROP_ALG_NONE      = 1    ! Don't evaluate
  integer, parameter    :: TROP_ALG_ANALYTIC  = 2    ! Analytic Expression
  integer, parameter    :: TROP_ALG_CLIMATE   = 3    ! Climatology
  integer, parameter    :: TROP_ALG_STOBIE    = 4    ! Stobie Algorithm
  integer, parameter    :: TROP_ALG_TWMO      = 5    ! WMO Definition, Reichler et al. [2003]
  integer, parameter    :: TROP_ALG_WMO       = 6    ! WMO Definition
  integer, parameter    :: TROP_ALG_HYBSTOB   = 7    ! Hybrid Stobie Algorithm
  integer, parameter    :: TROP_ALG_CPP       = 8    ! Cold Point Parabolic
  integer, parameter    :: TROP_ALG_CHEMTROP  = 9    ! Chemical tropopause
@nusbaume nusbaume added the cleanup This issue indicates an opportunity for code cleanup. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup This issue indicates an opportunity for code cleanup.
Projects
None yet
Development

No branches or pull requests

2 participants