Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htop_patch is being incorrectly used in FATES compsets #2945

Open
adrifoster opened this issue Jan 28, 2025 · 1 comment
Open

htop_patch is being incorrectly used in FATES compsets #2945

adrifoster opened this issue Jan 28, 2025 · 1 comment

Comments

@adrifoster
Copy link
Collaborator

Brief summary of bug

htop_patch is being incorrectly used in FATES compsets, especially (only?) when FATES SP-mode is on. This is because the htop_patch data structure is indexed by CLM PFTS whereas in FATES runs we should be using a data structure that is indexed by FATES PFTS.

see here for an example.

General bug information

CTSM version you are using: ctsm5.3.020

Does this bug cause significantly incorrect results in the model's science? Yes
Configurations affected: FATES, especially FATES-SP

@adrifoster
Copy link
Collaborator Author

This same logic applies to tlai_patch and tsai_patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant