Add ability for registry to specify input (IC) file variable names for constituents #259
Conversation
…eeded for constituents.
…erator (found via pylint test).
src/data/write_init_files.py
Outdated
| else: | ||
| # We need to work with the host model version of this variable | ||
| missing = _find_and_add_host_variable(stdname, host_dict, | ||
| const_dicts, req_vars) |
There was a problem hiding this comment.
do we still need to pass in const_dicts and include the constituents logic in _find_and_add_host_variable()?
There was a problem hiding this comment.
Well I tried running all of my tests (including doing snapshot runs) without it and it made no difference, so I am going to go with "no". const_dicsts has now been removed.
src/data/write_init_files.py
Outdated
| outfile.blank_line() | ||
| outfile.comment("Check if constituent standard name in registered SIMA standard names list:", 6) | ||
| outfile.write("if(any(phys_var_stdnames == ccpp_required_data(req_idx))) then", 6) | ||
| outfile.comment("Find array index to extract coorect input names:", 7) |
There was a problem hiding this comment.
typo - "correct" (i think)
There was a problem hiding this comment.
I think you are "correct"! Typo fixed.
src/data/write_init_files.py
Outdated
| outfile.blank_line() | ||
| outfile.comment("Check if constituent standard name in registered SIMA standard names list:", 5) | ||
| outfile.write("if(any(phys_var_stdnames == ccpp_required_data(req_idx))) then", 5) | ||
| outfile.comment("Find array index to extract coorect input names:", 6) |
There was a problem hiding this comment.
It was a harrowing journey, but I believe I have fixed it.
There was a problem hiding this comment.
Looks great @nusbaume!
Was hoping to at least find more spelling errors but it looks like @peverwhee beat me to the punch on them.
Add the ability for the registry to specify the possible variable names for constituents on an input or Initial Conditions (IC) file in CAM-SIMA. This should eliminate the need for an IC file to have only standard names for each variable, as long as the variable has the possible names listed in the registry.
Also, the
inputnames_to_stdnames.pyscript and associatedstdnames_to_inputnames_dictionary.xmlfile have now been moved to a newtoolsdirectory, as they should no longer be required for running CAM-SIMA (but could still potentially be useful for other situations).Finally, changes were made to remove the unused
configvariable from the registry generator, as pylint found that it wasn't actually being used for anything.Fixes #255