Implement model grid initialization for MPAS dynamical core #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Finish MPAS framework initialization. * Implement a generic mechanism for CAM-SIMA to input/output data to/from MPAS dynamical core. * Implement a generic mechanism for CAM-SIMA to exchange the halo layers of an arbitrary decomposed variable in MPAS dynamical core. * Implement accessor subroutines for users to access the internal states of MPAS dynamical core.
They are pointers, not values.
"Look before you leap". Make sure pointers are indeed associated before dereferencing them. Or runtime errors will ensue.
For developmental and testing purposes of MPAS dynamical core.
Fix the following issues related to standard conformance and/or compiler bugs: * Different character lengths in array constructor. * Logicals must be compared with `.eqv.` instead of `==`. * Deeply nested function calls generate wrong results. * `index_unique` function generates wrong results when the actual argument is a character string array.
nusbaume
requested changes
Apr 18, 2024
mgduda
reviewed
Apr 19, 2024
mgduda
reviewed
Apr 30, 2024
nusbaume
approved these changes
Apr 30, 2024
Switch to use pointers to conserve memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
model_grid_initsubroutine, which is responsible for initializing various model grids (e.g., dynamics, physics) in terms of dynamics decomposition. Additionally, MPAS framework initialization and reading time-invariant (e.g., grid/mesh) variables are also being done in this PR.Implementation notes:
dyn_mpas_init_phase3).dyn_mpas_read_write_stream) for CAM-SIMA to input/output data to/from MPAS dynamical core. This mechanism is the consolidation and generalization of thecam_mpas_read_static[1],cam_mpas_setup_restart[2],cam_mpas_read_restart[3] andcam_mpas_write_restart[4] subroutines in current CAM. Hundreds of lines of code are reduced as a result.dyn_mpas_exchange_halo) for CAM-SIMA to exchange the halo layers of an arbitrary decomposed variable in MPAS dynamical core.dyn_mpas_get_variable_pointer_*anddyn_mpas_get_variable_value_*families) for users to access the internal states of MPAS dynamical core.Test steps:
Observe log entries similar to the following in
atm.log.<job-id>.<date>-<time>: