Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have CAM-SIMA call the CCPP finalize step if a physics routine returns an error. #322

Open
nusbaume opened this issue Nov 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nusbaume
Copy link
Collaborator

nusbaume commented Nov 13, 2024

What is the feature/what would you like to discuss?

Right now in CAM-SIMA if any of the CCPP calls return a non-zero code the model immediately ends the run. However, this could leave the program in an unclean state when it stops.

To try and alleviate this potential problem, it would be beneficial for CAM-SIMA to call the CCPP finalize step (cam_ccpp_physics_finalize) before ending the run, which would give physics schemes a chance to perform cleanup (e.g. deallocate variables) before the program aborts.

Is there anyone in particular you want to be part of this conversation?

@jimmielin @mattldawson @boulderdaze @peverwhee

Will this change (regression test) answers?

No

Will you be implementing this enhancement yourself?

Any Software Engineer can do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

1 participant