Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong declaration of highsCompilationDate(), some compiler warnings, and a comment header #1798

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

svigerske
Copy link
Collaborator

  • Move declaration of highsCompilationDate() back to original location, as it should not be part of class Highs (the implementation is for highsCompilationDate() and not HiGHS::highsCompilationDate()).
  • Make new local functions static to fix missing declaration warnings.
  • Fix header
  • Avoid comparison of HighsInt and size_t.
  • Fix order of initializers in constructor to align to order of member declaration.

- move back to original position
- there is no implementation for HiGHS::highsCompilationDate(), but only
  for highsCompilationDate()
- fixes missing-declaration warning
- align to declaration order
@svigerske svigerske marked this pull request as ready for review June 11, 2024 09:26
@galabovaa
Copy link
Contributor

Thank you for these updates, @svigerske!

@galabovaa galabovaa merged commit 7689da7 into latest Jun 11, 2024
238 checks passed
@svigerske svigerske deleted the fix-warnings branch October 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants