Add new emodnet_thematic_lot column to emodnet_wfs() and explain what are thematic lots
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 91.82% 92.07% +0.25%
==========================================
Files 9 9
Lines 367 366 -1
==========================================
Hits 337 337
+ Misses 30 29 -1 ☔ View full report in Codecov by Sentry. |
|
Oh right, excellent idea, thank you!! |
annakrystalli
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Nice one @salvafern ! I think the extra column provides useful context. Overall looks good. I just had one question re: the vignette format conversion.
|
I'd like the vignette's tables to be kable, I'm fighting rmarkdown. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I recall we talked about adding a new column to
emodnet_wfs()to specify to what emodnet lot belongs every service (as thematic lots sometimes have more than one WFS endpoint for different services). This column would just be informative and maybe help to filter data from only specific lots.Not sure if we agreed on doing this or not, I hope it does not break compatibility. Let me know what you think!