Better alignment of footer elements in mobile mode #301
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was originally noticed by you @elichad, what do you think? |
|
Definitely an improvement, though still looks a bit disjointed to me since the text and logos are all mixed up. Maybe logos in one column and text in the other, if that's possible? Or text above and logos below. |
|
Sadly that would cause a complete reshuffle of the content, which I would like to prevent, to not confuse people, if they resize their window. Because these footers are completely customization, they can come in many shapes / combinations. |
|
Since this is the best I can get it for now, without making to many assumptions, I will merge this PR. If you have new ideas, please don't hesitate to open an issue about it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #266
Before:
After: