Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better alignment of footer elements in mobile mode #301

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

bedroesb
Copy link
Member

@bedroesb bedroesb commented Dec 3, 2024

This will close #266

Before:

image

After:

image

@bedroesb
Copy link
Member Author

bedroesb commented Dec 3, 2024

This was originally noticed by you @elichad, what do you think?

@elichad
Copy link
Contributor

elichad commented Dec 4, 2024

Definitely an improvement, though still looks a bit disjointed to me since the text and logos are all mixed up. Maybe logos in one column and text in the other, if that's possible? Or text above and logos below.

@bedroesb
Copy link
Member Author

bedroesb commented Dec 4, 2024

Sadly that would cause a complete reshuffle of the content, which I would like to prevent, to not confuse people, if they resize their window. Because these footers are completely customization, they can come in many shapes / combinations.

@bedroesb
Copy link
Member Author

Since this is the best I can get it for now, without making to many assumptions, I will merge this PR. If you have new ideas, please don't hesitate to open an issue about it!

@bedroesb bedroesb merged commit 002ae25 into main Dec 10, 2024
2 checks passed
@bedroesb bedroesb deleted the footer-clutter branch December 10, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer links and logos get out of line on tablet-sized screens
2 participants