New attribute page_img: logos for for pages and sections #290
Conversation
|
@PhilReedData Hey! Sorry it took so long to look at your pull request. I played around with some bootstrap classes. Could you have a look in how it behaves on your deployment? |
|
Thanks, I certainly will try that locally. Which remote call should I use now? To a particular tag/release of ETT? |
|
this is your branch still ! |
|
@PhilReedData |
|
Excellent, thank you. This is working really well for me.
|
|
Sorry something behaved different than I expected, you do have the latest version , let me check! |
|
Ah okay. I thought I had a later version because of the way the logo appears above the heading on the mobile view, that's changed from my code (changed for the better). |
|
@phil, can you point me to a place/branch where you try out the FAIRDOM Seek website with this version of the theme? The second screenshot show the logo to be be squeezed for example. and I think I want to play a little bit more with the spacings. |
|
Sure, it is here: https://github.com/FAIRdom/fairdom.github.io/tree/page-logos |
… into pr/PhilReedData/290-1
|
@PhilReedData I just discovered where I got confused. You are manually overwriting on the FAIRDOM website, the _includes/section-navigation-tiles.html. If you delete that one you can see my new version. |
|
I think most of the weird thing are gone now:
|
|
It's still giving me trouble with the TOC, Maybe we should make use of the TOC and put it above?
|
|
I deleted the local 'section-navigation-tiles.html' file, I don't know why we had that. Your code appears to be working now. That is a good point about the TOC, I didn't think of that. Yes, putting it within the column of the TOC at the top sounds wise, the same (max) width. Is that a conditional statement? to include the logo where it is, unless there is a TOC in which case put it there. |
As discussed, I have borrowed the
imagepage attribute from RO-Crate and used a newpage_imgattribute for pages to show a graphic such as a logo to the side of the page title. It also shows on the section navigation cards. There is no change to the rendered HTML in either place unless thepage_imgattribute appears in the front-matter of a page.More details and images are described in a Google Doc.
This has been tested on a branch of the FAIRDOM website, and in the ETT site itself. I used the following code in
_config.ymlto make a remote call:remote_theme: PhilReedData/elixir-toolkit-theme@page-img-007This is a fork from version 3.2.0. I did not mean to change the Gemfile.lock file.
To do
Sample images
More images in the linked Google Doc above.
