Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Possibly) refactor index construction #11

Open
tskir opened this issue Jun 18, 2020 · 0 comments
Open

(Possibly) refactor index construction #11

tskir opened this issue Jun 18, 2020 · 0 comments

Comments

@tskir
Copy link
Member

tskir commented Jun 18, 2020

Ii've not addressed this particular comment because having bot process in one causes some issue in the output channel. (specifically the order in the output channel needs to be known so that the right .fai can be used)

This might be due to my limited understanding of how nextflow works at this time but for now I would rather keep the explicit duplication.

About the second point. There is always a risk about using externally constructed index (with samtools/bowtie or others) but most tools have been pretty good at not changing their indexes between version. So the risk is limited and the saving in time and resources can be big.

Originally posted by @tcezard in #9

There are two points here:

  • Getting rid of possible code duplications
  • Looking into whether reusing external indexes is always safe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant