-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve phenotype EFO mappings #30
Comments
Ran on the same dataset as the 23.12 submission, using the mentioned PR and the other recent changes.
EFO coverage is better (33% -> 42%) but still not amazing, though the cystic fibrosis term highlighted in the OT issue is fixed. I've dumped unmapped phenotype terms in a spreadsheet here. Perhaps we can look at synonyms or terms provided by PGKB but I'm also wondering whether some of these super generic terms are in evidence being filtered out by OT anyway... e.g. "adverse events". |
With the explicit OLS check added, we bump up to 48.57%:
I've updated the list of unmapped terms as well. As Tim pointed out in the meeting, many of the more generic terms seem to occur in combination with other phenotypes in which context they might make more sense - e.g. for adverse events. |
Also cc @tskir, in case you are interested in the unmapped terms in particular. |
Refer to opentargets/issues#3149 for context. Tasks on our side:
The text was updated successfully, but these errors were encountered: