Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bile acid measurement" EFO_0020050 has unexpected definition and parent term #2324

Open
eks-ebi opened this issue Nov 25, 2024 · 5 comments
Assignees

Comments

@eks-ebi
Copy link
Collaborator

eks-ebi commented Nov 25, 2024

The term "bile acid measurement" (http://www.ebi.ac.uk/efo/EFO_0020050) has a mismatched definition related to diacylglycerol 30:1 levels and an unexpected parent term "sterol measurement" (http://www.ebi.ac.uk/efo/EFO_0010231).

The parent term might not be completely wrong, as bile acids are apparently "steroid acids" (https://en.wikipedia.org/wiki/Bile_acid) but it still doesn't sound quite like the most appropriate parent.

@eks-ebi eks-ebi added bug and removed bug labels Nov 25, 2024
@zoependlington zoependlington self-assigned this Nov 25, 2024
@zoependlington
Copy link
Collaborator

I have updated this definition and two others (diacylglycerol 30:1 levels and diacylglycerol 30:0 levels). For now I have kept bile acid measurement as a child of sterol measurement after discussing with the team and finding no better suited parent, but happy to update if you have any suggestions. These changes will be seen in the December release.

@eks-ebi
Copy link
Collaborator Author

eks-ebi commented Nov 25, 2024

Sounds great, thanks @zoependlington !

@eks-ebi
Copy link
Collaborator Author

eks-ebi commented Nov 25, 2024

I just got some follow-up suggestions for making the parent terms more precise/detail, in case you want to take these into account:

The term “bile acid measurement” should probably be made a child of “lipid measurement”
http://www.ebi.ac.uk/efo/EFO_0004529

If someone wanted to be really industrious, the existing term “glycholic acid measurement” should be made a child of “bile acid measurement”, since it is a specific bile acid.
http://www.ebi.ac.uk/efo/EFO_0010492

zoependlington added a commit that referenced this issue Nov 26, 2024
@zoependlington
Copy link
Collaborator

Thank you! I've updated the parents to make bile acid measurement a child of lipid measurement directly (previously a descendant through sterol measurement) and have made glycocholic alid measurement a child of bile acid measurement.

zoependlington added a commit that referenced this issue Nov 26, 2024
Updated incorrect definitions for #2324
@eks-ebi
Copy link
Collaborator Author

eks-ebi commented Nov 26, 2024

thanks Zoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants