Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the filter ratio threshold logic. Documentation stated that samples where less than 10% of reads were kept after filtering were flagged and not assembled. However the code was flagging samples that met this criteria:
(af_total_reads / bf_total_reads) <= params.filter_ratio_threshold
It was discarding samples where the proportion of passed reads was less than 90%. I've changed the filter threshold in the config to 10% to flag only the samples with less than 10% of the reads retained. I've also updated the description in the workflow and the README.
We haven't yet modified the tests affected by this change.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).README.md
is updated (including new tool citations and authors/contributors).