Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/long reads support structure refactor #17

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Feature/long reads support structure refactor #17

merged 8 commits into from
Nov 6, 2024

Conversation

mberacochea
Copy link
Member

Restructure the pipeline to support both Long Reads and Short Reads. This is still a work in progress.

@mberacochea mberacochea self-assigned this Sep 3, 2024
@Ge94 Ge94 marked this pull request as ready for review October 25, 2024 16:34
Ge94
Ge94 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@Ge94 Ge94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ready to merge now. I just added a couple edits here and there, harmonised a bit further and resolved the merge conflicts with the base branch. If we decide to leave parameter names as they are, happy to merge this PR.

nextflow.config Outdated Show resolved Hide resolved
subworkflows/local/long_reads_qc.nf Show resolved Hide resolved
tests/human/human.fna Show resolved Hide resolved
@mberacochea mberacochea merged commit 301aea1 into feature/long_read_qc Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ge94 Ge94 Ge94 approved these changes

Assignees

@mberacochea mberacochea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mberacochea @Ge94