Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants for states #186

Open
daviddavis opened this issue May 16, 2016 · 0 comments
Open

Use constants for states #186

daviddavis opened this issue May 16, 2016 · 0 comments

Comments

@daviddavis
Copy link
Contributor

daviddavis commented May 16, 2016 •
edited
Loading

I noticed in foreman-tasks that we're doing comparisons against hard-coded strings. Seems like it would be better to define states as constants (e.g. Dynflow::ExecutionPlan::STATE_STOPPED) so they can be programmatically accessed outside of dynflow.
@daviddavis daviddavis changed the title Use constants for task states Use constants for states May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daviddavis