Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#7007: Fix Doxygen install failures on Windows runners #7010

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

derekbruening
Copy link
Contributor

@derekbruening derekbruening commented Sep 27, 2024

Switches from directly downloading from sourceforge, which was giving us 403 errors suddenly after 4 years of working, to use https://github.com/ssciwr/doxygen-install which presumably will handle the changing versions for us (which was the problem when we used to directly download the doxygen packages). The downside may be that we'll keep getting newer versions and have to handle periodic warnings/failures: but we'd hit that eventually anyway on other platforms and is something we have to do anyway to maintain everything.

Also updates jwlawson/actions-setup-cmake from v1.8 to v2 as a problem was seen with that as well.

Fixes #7007

@derekbruening
Copy link
Contributor Author

Well Windows now works but all of a sudden the x86 ones all fail with:

Run jwlawson/[email protected]
  with:
    cmake-version: [3](https://github.com/DynamoRIO/dynamorio/actions/runs/11073381903/job/30769790989?pr=7010#step:6:3).19.7
    github-api-token: ***
Error: Failed request: ([5](https://github.com/DynamoRIO/dynamorio/actions/runs/11073381903/job/30769790989?pr=7010#step:6:6)00)

?!?

Could try v2 instead of v1.8 -- but why would this suddenly happen here?

@edeiana
Copy link
Contributor

edeiana commented Sep 27, 2024

Could try v2 instead of v1.8 -- but why would this suddenly happen here?

I thought we needed at least cmake v3.* anyway (or perhaps that refers to something else here?).

@derekbruening derekbruening merged commit 1374d52 into master Sep 27, 2024
17 checks passed
@derekbruening derekbruening deleted the i7007-win-doxy branch September 27, 2024 20:14
@derekbruening
Copy link
Contributor Author

Could try v2 instead of v1.8 -- but why would this suddenly happen here?

I thought we needed at least cmake v3.* anyway (or perhaps that refers to something else here?).

That is indeed something else: this v1.8 vs v2 is the version of the helper script which goes and downloads cmake 3.19.7:

    # Use a newer cmake to avoid 32-bit toolchain problems (i#4830).
    - name: Setup newer cmake
      uses: jwlawson/[email protected]
      with:
        cmake-version: '3.19.7'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants