Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3544 RV64: Port more sample tests to RISC-V #6766

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

ksco
Copy link
Contributor

@ksco ksco commented Apr 10, 2024

Ports sample.opcodes and sample.callstack tests to RISC-V.

Unlike other architectures, there are no control flags in RISC-V, we use common.hello as the application to run sample tests, sample.callstack.control_flags.templatex is renamed to sample.callstack.templatex.

sample.callstack is yet another test that does not run on QEMU.

Issue: #3544

@ksco
Copy link
Contributor Author

ksco commented Apr 10, 2024

I noticed sample.callstack test passed on my local x86_64 dev machine with QEMU v7.1.0, but failed in CI, so I took a look on the CI env. using tmate:

runner@fv-az1427-290:~/work/dynamorio/dynamorio/build_riscv64-debug-internal$ qemu-riscv64 --version
qemu-riscv64 version 6.2.0 (Debian 1:6.2+dfsg-2ubuntu6.18)
Copyright (c) 2003-2021 Fabrice Bellard and the QEMU Project developers
runner@fv-az1427-290:~/work/dynamorio/dynamorio/build_riscv64-debug-internal$ qemu-riscv64 -L /usr/riscv64-linux-gnu bin64/drrun -debug -xarch_root /usr/riscv64-linux-gnu -stderr_mask 0xC -c api/bin/libcallstack.so -- suite/tests/bin/common.hello
wrapping /usr/riscv64-linux-gnu/lib/libc.so.6!malloc
malloc called from:
Segmentation fault (core dumped)
runner@fv-az1427-290:~/work/dynamorio/dynamorio/build_riscv64-debug-internal$

Maybe this is simply because QEMU is too old? Will try to upgrade QEMU in future PR to enable more tests.

@ksco ksco requested a review from derekbruening April 10, 2024 10:55
ext/drcallstack/drcallstack.c Outdated Show resolved Hide resolved
@ksco ksco merged commit 8a8c10f into DynamoRIO:master Apr 11, 2024
16 checks passed
@ksco ksco deleted the i3544-porting-tests branch April 11, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants