i#6495 syscall templates: Avoid buffer overflow at instr_no_fetch #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we write out the buffered entries at each no_fetch repstr instance. This is to avoid overflowing the write buffer, since some syscall trace templates have repstr with high iteration count. Adds a unit test to the existing burst_syscall_inject test that verifies injection of a syscall template with a large repstr iteration count. Issue: #6495
abhinav92003
changed the title
abhinav92003
changed the title
derekbruening
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes out the buffered entries at each instr_no_fetch instance. This is to avoid overflowing the raw2trace write buffer, since some syscall trace templates have repstr with a very high iteration count.
Adds separate tracking in the basic counts tool for user and kernel nofetch instrs.
Adds a unit test to the existing burst_syscall_inject test that verifies injection of a syscall template with a high repstr iteration count. Also removes some log spam in the burst_syscall_inject test.
Issue: #6495