Fix dr_insert_clean_call callee arg in tutorial #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav92003
requested changes
Jun 5, 2023
Pavel-Durov
changed the title
abhinav92003
approved these changes
Jun 6, 2023
|
Thanks for the fix. I'll add this to our merge queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the callee arg in the dr_insert_clean_call call in the dynamic basic block size tutorial. The callee pointer should be cast to
void*for it to compile successfully.Related to: https://groups.google.com/g/dynamorio-users/c/BWVdySjLUn8