From ac8f6f3e97cf513f3434c8e78b43706364299295 Mon Sep 17 00:00:00 2001 From: Abhinav Anil Sharma Date: Wed, 10 Apr 2024 17:38:36 -0400 Subject: [PATCH] Add comment --- clients/drcachesim/tools/invariant_checker.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/drcachesim/tools/invariant_checker.cpp b/clients/drcachesim/tools/invariant_checker.cpp index 382a2ba4c63..e36cdb182bd 100644 --- a/clients/drcachesim/tools/invariant_checker.cpp +++ b/clients/drcachesim/tools/invariant_checker.cpp @@ -1123,6 +1123,9 @@ invariant_checker_t::parallel_shard_memref(void *shard_data, const memref_t &mem || shard->prev_instr_.decoding.is_xrstor // xsaveopt also reads some fields from the xsave // header (https://www.felixcloutier.com/x86/xsaveopt). + // XXX: Same as above, can we store any metadata in the + // trace to allow us to adapt the decoder to expect + // this? || shard->prev_instr_.decoding.opcode == OP_xsaveopt64 || shard->prev_instr_.decoding.opcode == OP_xsaveopt32))), "Too many read records");