s/scheduleable/schedulable/; make it clear print_queue_stats() verbos…

…ity check should be in caller
DynamoRIO · Oct 3, 2024 · 695db09 · 695db09
1 parent 2acb4a3
commit 695db09
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/clients/drcachesim/scheduler/scheduler.cpp b/clients/drcachesim/scheduler/scheduler.cpp
@@ -4244,7 +4244,7 @@ scheduler_tmpl_t<RecordType, ReaderType>::print_queue_stats()
     int live = live_input_count_.load(std::memory_order_acquire);
     // Make our multi-line output more atomic.
     std::ostringstream ostr;
-    ostr << "Queue snapshot: inputs: " << live - unsched_size << " scheduleable, "
+    ostr << "Queue snapshot: inputs: " << live - unsched_size << " schedulable, "
          << unsched_size << " unscheduled, " << inputs_.size() - live << " eof\n";
     for (unsigned int i = 0; i < outputs_.size(); ++i) {
         auto lock = acquire_scoped_output_lock_if_necessary(i);
@@ -4269,7 +4269,7 @@ scheduler_tmpl_t<RecordType, ReaderType>::print_queue_stats()
         for (input_info_t *add : readd)
             outputs_[i].ready_queue.queue.push(add);
     }
-    VPRINT(this, 1, "%s\n", ostr.str().c_str());
+    VPRINT(this, 0, "%s\n", ostr.str().c_str());
 }
 
 template <typename RecordType, typename ReaderType>

diff --git a/clients/drcachesim/scheduler/scheduler.h b/clients/drcachesim/scheduler/scheduler.h
@@ -1581,6 +1581,7 @@ template <typename RecordType, typename ReaderType> class scheduler_tmpl_t {
     rebalance_queues(output_ordinal_t triggering_output,
                      std::vector<input_ordinal_t> inputs_to_add);
 
+    // Up to the caller to check verbosity before calling.
     void
     print_queue_stats();
 

diff --git a/clients/drcachesim/tests/scheduler_unit_tests.cpp b/clients/drcachesim/tests/scheduler_unit_tests.cpp
@@ -5055,7 +5055,7 @@ test_unscheduled_initially()
                              std::unique_ptr<mock_reader_t>(new mock_reader_t()), TID_A);
         readers.emplace_back(std::unique_ptr<mock_reader_t>(new mock_reader_t(refs_B)),
                              std::unique_ptr<mock_reader_t>(new mock_reader_t()), TID_B);
-        // We have a medium idle period before A becomes scheduleable.
+        // We have a medium idle period before A becomes schedulable.
         static const char *const CORE0_SCHED_STRING =
             "...B....._____.....A.__________________________________B....B.";