DYN-6969 refactor: migrate UITests to RTL #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzo707
force-pushed
the
DYN-6969/migrate-tests-from-enzyme-to-react-testing-library
branch
from
e5cb632
to
c68a1c6
Compare
Enzo707
force-pushed
the
DYN-6969/migrate-tests-from-enzyme-to-react-testing-library
branch
4 times, most recently
from
466bbdf
to
ec6217c
Compare
Enzo707
force-pushed
the
DYN-6969/migrate-tests-from-enzyme-to-react-testing-library
branch
from
ec6217c
to
a764e38
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the tests migration from Enzyme to React Testing Library and fix the snapshot tests issues.
Ref.: DYN-6969
Ref.: DYN-6970
It's important to remember that as we have troubles to run the tests, because of some component's life cycle issues, we decided to comment this%20%3D%3E%20%7B-,//%20The%20commented%20code%20below%20affects%20tests.%20This%20needs%20to%20be%20address,//%20%7D,-%7D) in order to move on with the migration and revisit the issue after we finished.
I've explained the details to @RobertGlobant20 however I'll be available if you need any additional info.