Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change hard-coded references to the type (gEdge in this case) to use this.GetType().ToString() in all occurrences of this pattern #41

Open
SHKnudsen opened this issue Mar 27, 2019 · 1 comment
Open

change hard-coded references to the type (gEdge in this case) to use this.GetType().ToString() in all occurrences of this pattern #41

SHKnudsen opened this issue Mar 27, 2019 · 1 comment
Assignees
@SHKnudsen
Labels
enhancement An improvement to current functionality or codebase

Comments

@SHKnudsen
Copy link
Collaborator

change hard-coded references to the type (gEdge in this case) to use this.GetType().ToString() in all occurrences of this pattern

Originally posted by @radumg in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MjE5MzAyODgy/pull_request_reviews/more_threads
@SHKnudsen SHKnudsen self-assigned this Mar 27, 2019
@SHKnudsen SHKnudsen added the enhancement An improvement to current functionality or codebase label Mar 27, 2019
@SHKnudsen SHKnudsen mentioned this issue Mar 27, 2019
Merged
@radumg
Copy link
Collaborator

radumg commented Jun 12, 2019

better yet, use compile-time constant nameof(gEdge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SHKnudsen SHKnudsen

Labels
enhancement An improvement to current functionality or codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radumg @SHKnudsen