Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Consistency - Packing.PackCuboids #148

Open
johnpierson opened this issue Jan 13, 2021 · 0 comments
Open

Node Consistency - Packing.PackCuboids #148

johnpierson opened this issue Jan 13, 2021 · 0 comments

Comments

@johnpierson
Copy link
Member

johnpierson commented Jan 13, 2021

image

Description

No proposed changes

Inputs

No proposed changes

Outputs

Original Output Name Replacement Reason
Packed Items packedItems
Packed Indices packedIndices
Remaining Items remainingIndices because this node actually returns indices on this port
% Container Volume Packed percentContainerVolumePacked
% Item Volume Packed percentItemVolumePacked

Reasoning

To further align the nodes with the Dynamo Core consistency pass previously completed. This includes camelCase and whole word consistency.

Additionally, this includes the removal of the special characters as this helps guide people to avoid this convention when possible. If the percent symbol is preferred, I would leave it but still add camelCase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant