Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CO_f1ecac in the overview table #37

Open
jhossbach opened this issue Sep 1, 2024 · 4 comments
Open

Missing CO_f1ecac in the overview table #37

jhossbach opened this issue Sep 1, 2024 · 4 comments

Comments

@jhossbach
Copy link

Hey,
I was looking for a description of the CO_f1ecac feature in the overview table but there doesn't seem to be any mention of that feature.
I think it might have existed at some point in time, but I am not sure.

Cheers

@benfulcher
Copy link
Collaborator

This has been renamed as first1e_acf_tau or acf_timescale. Please see here for details: https://time-series-features.gitbook.io/catch22/information-about-catch22/feature-descriptions/feature-overview-table

@benfulcher
Copy link
Collaborator

Let me know if that deprecated name is still about in the code and we can fix to avoid confusion. Thanks for flagging!

@jhossbach
Copy link
Author

Ah, I meant to post this issue on the pycatch22 repo.

There it seems like the normal name was not updated:

>>> features = pycatch22.catch22_all([1,2,3], short_names=True)
>>> "CO_f1ecac" in features["names"]
True
>>> "first1e_acf_tau" in features["names"]
False
>>> "acf_timescale" in features["short_names"]
True

Tested on pycatch22 v0.4.5

@benfulcher
Copy link
Collaborator

Ok thanks @jmoo2880 will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants