Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lifecycle events? #7

Open
luzlab opened this issue Jan 14, 2020 · 2 comments
Open

Support lifecycle events? #7

luzlab opened this issue Jan 14, 2020 · 2 comments

Comments

@luzlab
Copy link

luzlab commented Jan 14, 2020

I appreciate this library and use it in several projects. Recently, I've had a use case where I need to run a function whenever a key is evicted. I made a fork and added an eventemitter to support this.

Would you be interested in a PR? If so, I'd appreciate feedback on what changes you think would be appropriate.

@DylanPiercey
Copy link
Owner

@luzlab I'd be concerned with the performance overhead of adding an event emitter here.

I feel like perhaps a fork would make more sense? If it could be implemented concisely and without a performance impact then I'd be less opposed.

@luzlab
Copy link
Author

luzlab commented Feb 10, 2020

I opened a PR #8 with the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants