Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto device discovery #15

Open
santarl opened this issue Nov 11, 2024 · 4 comments
Open

Add auto device discovery #15

santarl opened this issue Nov 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@santarl
Copy link
Collaborator

santarl commented Nov 11, 2024

Instead of adding ip address manually, have it auto detect running instances and offer to connect.

One approach would be to:

  • host a mDNS server (or similar service) on the pc side (rust app) and have it broadcast itself
  • have the vita detect it send a packet to it with its own ip
  • which the rust app accepts and initiates the connection to.

I prefer the above approach instead of having the vita broadcast itself because idk if u can host a mDNS server on vita although that would makes things a lot simpler

hmmmmm

@DvaMishkiLapa
Copy link
Owner

Yes, we can try a Broadcast packet on a network with special content like Heartbeat.

We can only hope that some clever Windows firewall doesn't interfere with this.

@DvaMishkiLapa
Copy link
Owner

On the other hand, it's not exactly safe.

Theoretically, someone could pretend to be a PS Vita device and the client would connect automatically.

There needs to be a mechanism to confirm and warn users so they don't mindlessly accept the first search option while sitting on a public network with 50ms latency xD

@santarl
Copy link
Collaborator Author

santarl commented Nov 11, 2024

Theoretically, someone could pretend to be a PS Vita device and the client would connect automatically.

we can use some kinda pin like moonlight / sunshine does it for first time.

after that we can have the devices verify themselves with keys ig

@DvaMishkiLapa DvaMishkiLapa added the enhancement New feature or request label Nov 12, 2024
@saidsay-so
Copy link

FWIW, I was messing with a custom discovery logic based on multicast which would be like the one you suggested with mDNS, because I judged that mDNS would be too much work at the time.
I also wanted to invert the client-server relationship because it makes more sense, but I didn't have the opportunity to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants