Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Editing Message not working and causing app to crash #722

Closed
Dun-sin opened this issue Nov 21, 2024 · 5 comments · Fixed by #734
Closed

[BUG] Editing Message not working and causing app to crash #722

Dun-sin opened this issue Nov 21, 2024 · 5 comments · Fixed by #734
Assignees
Labels
7 days Not more than 7 days(1week) to raise a PR assigned backend this issue requires knowlegde of backend bug Something isn't working hacktoberfest 🏁 status: ready for dev issue is ready to be worked on

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Nov 21, 2024

Description

in sockets for editMessage we get this error:

      if (!isMessageEditableOrDeletable(chatId, messageId)) {
      ^

ReferenceError: isMessageEditableOrDeletable is not defined

Steps to Reproduce

Set up the project as usual or go to the live link
Join a chat
Send a Message
Click on the dropdown icon
Click on editing the message

@Dun-sin Dun-sin added bug Something isn't working hacktoberfest 🚦 status: awaiting approval waiting for maintainer to accept issue as ready to work labels Nov 21, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are valid/approved and to be assigned. In the meantime read the contributing guidelines -> https://github.com/Dun-sin/Whisper/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@Dun-sin Dun-sin added up for grabs anyone can ask to work on this backend this issue requires knowlegde of backend 7 days Not more than 7 days(1week) to raise a PR 🏁 status: ready for dev issue is ready to be worked on and removed 🚦 status: awaiting approval waiting for maintainer to accept issue as ready to work labels Nov 21, 2024
@github-actions github-actions bot unlocked this conversation Nov 21, 2024
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you.

@amishabaraskar
Copy link

Hi @Dun-sin ,

I want to work on this issue. I can check the problem with the socket. Thanks

@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 22, 2024

I want to work on this issue. I can check the problem with the socket. Thanks

Sure @amishabaraskar, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@Dun-sin Dun-sin added assigned and removed up for grabs anyone can ask to work on this labels Nov 22, 2024
@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 29, 2024

@amishabaraskar the time allocated to this PR is over, please submit your PR today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7 days Not more than 7 days(1week) to raise a PR assigned backend this issue requires knowlegde of backend bug Something isn't working hacktoberfest 🏁 status: ready for dev issue is ready to be worked on
Projects
None yet
2 participants