-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.5 NOCHANGE: Hangprinter: simplify things by turning unrolled stuff into loops #597
base: 3.5-dev
Are you sure you want to change the base?
Conversation
049b547
to
44d22c2
Compare
Updated the code and the testing status on the PR description. TLDR: now it compiles again. |
Otherwise it gets too deep. I think there's an option in eclipse to forbid this by project in format, one can config depness iirc.
44d22c2
to
e19697e
Compare
Finally tested this a bit. There were some bugs in M666 that are corrected now. |
Oh, well, I guess I also didn't test PrintParameters(). |
I think there's a manual procedure that let's you collect the same bed height mesh data that a probe would collect, it just takes a lot more time to step through. |
I will unfortunately be away from my Hangprinter for three to four weeks. I'll try to think about ways we could test this without access to physical machine. |
I made two commits on top of this branch. You can find them here: https://github.com/tobbelobb/RepRapFirmware/commits/3.5-dev-hangprinter-simplify They have not been compiled and tested. The change to I didn't manage to get rid of |
Thank you. It looks good at a glance. More anchor treatment turned into loops. I made a single comment in one of the commits though: tobbelobb@a335f44#r108198467 Perhaps it would be better if we left those 2 commits for a different PR on top of this one? |
I looked at the this is wrong-link. What made you change the 11 to 14 in the first place? We need @dc42 for input on the object model. I'm currently unaware of any currently active uses of Hangprinter's entries in the object model. We shouldn't let it slow us down if we don't have to. |
This is a rebased version of #584 in the 3.4-dev branch.
The main goal is to make it easier to get support for more than 4 anchors in the hangprinter kynematics.
This PR shouldn't change functionality at all. If it does, that's a bug.
Testing status:
Everything seems to work, I still haven't tested the changes in WriteCalibrationParameters()
But not with a real hangprinter, my config is different with 4 anchors on top and not really ready to print anything, just moving the headtool around for now.
Real hangprinter testers welcomed.