Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXP1HCL brake PWM is not applied under some conditions #1050

Closed
dc42 opened this issue Sep 24, 2024 · 2 comments
Closed

EXP1HCL brake PWM is not applied under some conditions #1050

dc42 opened this issue Sep 24, 2024 · 2 comments
Assignees
@dc42
Labels
bug Bug that has been reproduced
Milestone
3.5.4

Comments

@dc42
Copy link
Collaborator

dc42 commented Sep 24, 2024 •
edited
Loading

If I run the following sequence:

  1. Run a macro that includes the following lines (note that "brake" is not a valid pin number):
M584 X123.0
M569.7 P123.0 C"brake" V24
M569.1 P123.0 T2 S200 C1000 R15 I200 D0.02 A250000 V800
M906 X3000
M569 P123.0 D2
M17 X
  1. Run the same macro with "brake" corrected to "brake.neg"

then brake PWM is no longer applied, the full voltage is applied to the brake. This bug is present in at least 3.5.3 and in 3.6.0-beta.1.
@dc42 dc42 added the bug Bug that has been reproduced label Sep 24, 2024
@dc42 dc42 added this to the 3.5.4 milestone Sep 24, 2024
@dc42 dc42 self-assigned this Sep 24, 2024
@dc42
Copy link
Collaborator Author

dc42 commented Sep 25, 2024

Simpler way to reproduce this issue: enable the motor using M17 before using M569.7 to configure the brake port.

@dc42
Copy link
Collaborator Author

dc42 commented Sep 25, 2024

Fixed and tested in 3.5-dev and 3.6-dev.

@dc42 dc42 closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dc42 dc42

Labels
bug Bug that has been reproduced
Projects
None yet
Milestone
3.5.4
Development

No branches or pull requests
1 participant
@dc42