Discontinue old API used for Mapbox projects/classic, replace with Mapbox Studio styled raster tiles #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oaamaas <[email protected]>
Signed-off-by: oaamaas <[email protected]>
Signed-off-by: oaamaas <[email protected]>
…ils.java: https://api.mapbox.com/styles/v1/ Signed-off-by: oaamaas <[email protected]>
https://api.mapbox.com/styles/v1/ Original API was depending in the phased out approach with Mapbox projects, and the use of the retured Mapbox Classic app. The API introduced utilizes the current Mapbox Studio's abilities to create styles, and to modify these styles with tilesets and other customizations The API requires: - The Mapbox Account name: As introduced in multiple file as mapboxUserId - The Style ID: Re-used the mapId for this purpose since the old API is phased out anyway - The Mapbox token, already present in previous versions of Tower Solution fully working, but has a flaw when user selects "flight data screen" (no flaw in screens for editor and history: - Tower loads normal maps from Google, but does not overlay the styled tiles - Workaround: Change orientation of device, and the styled tiles are overlaid The flaw is caused by logic in DroneMap.java, the following IF concludes wether or not tiles should be overlaid: if (mMapFragment == null || mMapFragment.getProvider() != mapProvider) (line 294) Should be corrected, but Mapbox in Tower is now fully functional with the workaround. Signed-off-by: oaamaas <[email protected]>
Removed import of disabled leakcanary in DroidPlannerApp Signed-off-by: oaamaas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapbox integration was faulty after Mapbox discontinued their "Projects" and stopped developing Mapbox Classic. New solution for map designers (or anyone interested in creating a free account to use their services) is Mapbox Studio. Tower threw error messages of incorrect credentials, but could partly display mapbox maps if . was entered into Tower Map ID field.
This pull request solves the error messages by switching out the API to retrieve raster tiles from styles. API documented here: https://docs.mapbox.com/api/maps/#retrieve-raster-tiles-from-styles
To support this API, a field to capture the users mapbox user name is introduced. In addition, the mapId field is re-used to enter the ID of the style rather than the mapId. Two API calls to retrieve additional "markers" and "polygons" are disabled since I had problems to support that and saw no obvious use case. But if these objects are included into their mapbox style, they will be retrieved by Tower anyway. In addition, the leak canary is disabled in this PR.
Solution works almost flawless. One problem remains: When user select the flight data screen, the style tiles are not shown. Seems to be caused in DroneMap.java, where use case start flight data only trigger function onStart(), while use cases starting editor/history/"flip orientation" all have a preceding call to onCreateView() upfront of onStart(). The workaround in flight data screen: Rotate device (horisontal <=> portrait), and mapbox tiles becomes visible again.