🔧 This addresses the case where the image of the ProfileCard used for sharing on SNS etc. is corrupted in some cases. #928
+47
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sharing on SNS etc. is corrupted in some cases. This was addressed by using the CompositionLocalProvider to ensure that the composable for taking photos has a fixed density and font scale.
|
Detekt check failed. Please run |
…rectly, so I applied the same fix as the others.
Corvus400
commented
Sep 2, 2024
Comment on lines
+64
to
+69
| CompositionLocalProvider( | ||
| LocalDensity provides Density( | ||
| density = 1f, | ||
| fontScale = 1f, | ||
| ), | ||
| ) { |
There was a problem hiding this comment.
If fontScale is not set to a fixed value, the text will either overflow or become smaller if the device settings are changed.
So, I used the CompositionLocalProvider to fix the density and font scale of the composable for taking photos so that the display would not break.
There was a problem hiding this comment.
I have never thought of this before. This is super smart 👀
Corvus400
commented
Sep 2, 2024
| @@ -108,7 +108,7 @@ private fun ShareableCardContent( | |||
| ) | |||
| .background(LocalProfileCardTheme.current.primaryColor), | |||
| ) { | |||
| Box(modifier = Modifier.padding(vertical = 30.dp)) { | |||
| Box(modifier = Modifier.padding(vertical = with(density) { verticalPaddingPx.toDp() })) { | |||
There was a problem hiding this comment.
This part has been forgotten to be modified, and is one of the causes of the display corruption when in landscape mode.
…ile_card_when_small_phone
takahirom
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)