Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 We have made some modifications to the profile card screen so that focus is handled appropriately. #924

Merged
merged 2 commits into from
Sep 2, 2024
Merged

🔧 We have made some modifications to the profile card screen so that focus is handled appropriately. #924

merged 2 commits into from
Sep 2, 2024
+13 −0

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 2, 2024 •
edited
Loading

Issue

Overview (Required)

  • I have made it so that the focus is cleared at the following times.
  1. When you tap anywhere on the screen.
  2. When you perform the Done action on the last item.

Movie (Optional)

Before After
before.mp4
after.mp4

@Corvus400
🔧 The focus on the item has been adjusted so that it is properly remo…
5048a0d 
…ved.

1. When you tap anywhere on the screen.
2. When you perform the Done action on the last item.
@Corvus400
🔧 ./gradlew detekt --auto-correct
cbea568
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 2, 2024 01:10 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 2, 2024 01:28
takahirom
takahirom approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit 24ec63a into DroidKaigi:main Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In EditScreen, it would be better to take the focus off the text field once the keyboard is hidden
2 participants
@Corvus400 @takahirom