Apply timetable item(session) detail design roughly #85
Conversation
|
Thanks. I'll take a look shortly! |
There was a problem hiding this comment.
renamed directory to enable the use of vector images
| modifier: Modifier = Modifier, | ||
| ) { | ||
| // TODO: switch color according to room type | ||
| TopAppBar( |
There was a problem hiding this comment.
I'm not using LargeTopAppBar. Implementing this on the title would disrupt the layout. So, I implemented to TimeTableItemDetailHeadline 🙇
| TopAppBar( | ||
| modifier = modifier, | ||
| colors = TopAppBarDefaults.topAppBarColors().copy( | ||
| containerColor = Color(0xFF132417), |
There was a problem hiding this comment.
I haven't implemented the logic to switch colors based on room type 🙇
hardcoded the color for Arctic Fox...
| @Composable | ||
| @MultiThemePreviews | ||
| @MultiLanguagePreviews | ||
| fun TimetableItemDetailTopAppBarUnSelectablePreview() { |
There was a problem hiding this comment.
Are others also experiencing the issue where the Compose Preview cannnot be displayed in Android Studio (with the icon not appearing as shown in picture)?
There was a problem hiding this comment.
Yeah, I know this problem. You can refer to https://speakerdeck.com/ogi2ogi/get-started-with-compose-multiplatform?slide=24 for more information.
There are some solutions, but generally, we can't see the preview using Android Studio with commonMain.
I recommend running ./gradlew recordRoborazziDebug and using the Roborazzi Idea Plugin.
You can find it here: https://plugins.jetbrains.com/plugin/24561-roborazzi
| Modifier.padding( | ||
| top = innerPadding.calculateTopPadding(), | ||
| ), | ||
| LazyColumn( |
| Text( | ||
| text = "続きを読む", | ||
| style = MaterialTheme.typography.labelLarge, | ||
| color = Color(0xFF45E761), |
There was a problem hiding this comment.
It's OK to merge this but could you add comments for each Colors that we could fix this after?
// FIXME: Implement and use a theme color instead of fixed colors like RoomColors.primary and RoomColors.primaryDim
There was a problem hiding this comment.
Understood. I handled it with this PR 🙇
#90
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
2024-07-02.23.41.01.mov
2024-07-02.23.42.14.mov