-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify to change the display message based on whether the search text is empty or not #843
Modify to change the display message based on whether the search text is empty or not #843
Conversation
Sorry, I should have shared this earlier. 🙇 |
@takahirom Lines 153 to 154 in be38af7
Are you referring to a different case? input_and_filter_and_empty_and_batsu.mp4 |
Thank you for providing the video. In the video, I would like to have a UFO image and text appear at the 8-second and 20-second points. I would also like to display a UFO image when the text is empty after searchs. |
I see. So, are the conditions for displaying the image and message as follows?
Conversely, the image and message are not displayed under the following condition:
|
Your understanding seems correct. I have checked with the designer regarding when this specification came from them. |
Thank you very much! input_category_and_empty.mp4 |
I don't think it is a major use case. I think you can decide based on which implementation is easier. |
OK, then I will not handle searches with only categories. finaly_input_and_empty.mp4 |
Detekt check failed. Please run |
@@ -50,6 +50,7 @@ fun searchScreenPresenter( | |||
val sessions by rememberUpdatedState(sessionsRepository.timetable()) | |||
|
|||
var searchWord by rememberRetained { mutableStateOf("") } | |||
var hasSearched by rememberRetained { mutableStateOf(false) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for collaborating with us.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
When there is input