Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add : add Medium TopBar #753

Merged
merged 7 commits into from
Sep 2, 2024
Merged

add : add Medium TopBar #753

merged 7 commits into from
Sep 2, 2024

Conversation

choi-woo-sung
Copy link
Contributor

@choi-woo-sung choi-woo-sung commented Aug 23, 2024 •
edited
Loading

change Topbar beacuse Staff Screen TobBar not matched

Issue

Overview (Required)

  • change LargeTobBar into MediumTobBar

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@choi-woo-sung
add : add Medium TopBar
8197157 
change Topbar beacuse Staff Screen TobBar not matched
@github-actions GitHub Actions
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 12:35 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Snapshot diff report

File name Image
ContributorsScreenTe
st[ContributorsScree
n - when server is o
perational - when se
rver is down - when
launch - it should d
oes not show contrib
utor and show snackb
ar]_compare.png
ContributorsScreenTe
st[ContributorsScree
n - when server is o
perational - when la
unch - it should sho
w first and second c
ontributors]_compare
.png
ContributorsScreenTe
st[ContributorsScree
n - when server is o
perational - when la
unch - when scroll t
o index 10 - it shou
ld show contributors
]_compare.png
SettingsScreenTest[S
ettingsScreen - when
launch use font def
ault system font - w
hen click use font i
tem - when click dot
gothic font - it sh
ould selected dot go
thic font]_compare.p
ng
SettingsScreenTest[S
ettingsScreen - when
launch use font dot
gothic - when click
use font item - whe
n click system defau
lt font - it should
selected system defa
ult font]_compare.pn
g
SettingsScreenTest[S
ettingsScreen - when
launch use font dot
gothic - when click
use font item - it
should show availabl
e fonts]_compare.png
SettingsScreenTest[S
ettingsScreen - when
launch use font def
ault system font - w
hen click use font i
tem - it should show
available fonts]_co
mpare.png
SettingsScreenTest[S
ettingsScreen - when
launch use font def
ault system font - i
t should show settin
gs contents]_compare
.png
SettingsScreenPrevie
w_compare.png
SettingsScreenTest[S
ettingsScreen - when
launch use font def
ault system font - w
hen click use font i
tem - when click sys
tem default font - i
t should selected sy
stem default font]_c
ompare.png
SettingsScreenTest[S
ettingsScreen - when
launch use font dot
gothic - it should
show settings conten
ts]_compare.png
SettingsScreenTest[S
ettingsScreen - when
launch use font dot
gothic - when click
use font item - whe
n click dot gothic f
ont - it should sele
cted dot gothic font
]_compare.png
SponsorsScreenPrevie
w_compare.png
SponsorsScreenTest[S
ponsorsScreen - when
server is operation
al - when launch - w
hen scroll to gold s
ponsors header - it
should display gold
sponsors]_compare.pn
g
SponsorsScreenTest[S
ponsorsScreen - when
server is operation
al - when launch - i
t should display pla
tinum sponsors]_comp
are.png
SponsorsScreenTest[S
ponsorsScreen - when
server is operation
al - when launch - w
hen scroll to scroll
Bottom - it should
display supporters s
ponsors]_compare.png
SponsorsScreenTest[S
ponsorsScreen - when
server is down - wh
en launch - it shoul
d does not show spon
sors and show snackb
ar]_compare.png
StaffScreenPreview_c
ompare.png
StaffScreenTest[Staf
fScreen - when serve
r is operational - w
hen launch - when sc
roll to index 10 - i
t should show staffs
]_compare.png
StaffScreenTest[Staf
fScreen - when serve
r is operational - w
hen launch - it shou
ld show first and se
cond staffs]_compare
.png
StaffScreenTest[Staf
fScreen - when serve
r is operational - w
hen server is down -
when launch - it sh
ould does not show s
taff and show snackb
ar]_compare.png

@takahirom
Copy link
Member

Thank you for your pull request!
We have many screens like this. I'd like to maintain consistency here. It might be challenging, but could you take a look?

@choi-woo-sung
Copy link
Contributor Author

choi-woo-sung commented Aug 26, 2024 •
edited
Loading

@takahirom Okay. I try it!

@takahirom
Copy link
Member

Thanks!

@choi-woo-sung
Copy link
Contributor Author

@takahirom
i fix it
image

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 28, 2024 01:46 Inactive
@takahirom
Copy link
Member

@choi-woo-sung, could you please check the failing tests? 🙏

@choi-woo-sung
Copy link
Contributor Author

@choi-woo-sung, 실패한 테스트를 확인해 주시겠어요? 🙏

ok sorry..

@github-actions GitHub Actions
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@choi-woo-sung
Copy link
Contributor Author

choi-woo-sung commented Sep 2, 2024 •
edited
Loading

@takahirom

i fix it !!

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 2, 2024 08:54 Inactive
takahirom
takahirom approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit a462654 into DroidKaigi:main Sep 2, 2024
6 checks passed
@takahirom takahirom mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust the spacing between the up button and title to match the Figma design.
3 participants
@choi-woo-sung @takahirom @mikanIchinose